This repository was archived by the owner on Jan 24, 2018. It is now read-only.
Added a modifier mechanism for rounding interpolated values#569
Open
jkphl wants to merge 1 commit intoPrinzhorn:masterfrom
Open
Added a modifier mechanism for rounding interpolated values#569jkphl wants to merge 1 commit intoPrinzhorn:masterfrom
jkphl wants to merge 1 commit intoPrinzhorn:masterfrom
Conversation
|
Thank you @jkphl, it works! I have similar requirement when dealing with element's height. Tiny whitespace may appear below the element if floating point number is used in height value so rounding does the trick. This PR works great for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a simple mechanism for (optionally) applying modifications to interpolated values. I needed this for animating the
srcproperty of<img>elements. Imagine this:While skrollr is able to interpolate the image filename, it will eventually produce floating point numbers — which doesn't make sense here of course. I needed the interpolated values to stay integers, so they need to be rounded. I introduced
°as another modifier (similar to!for preventing interpolation altogether) for exactly this purpose:This will result in
srcvalues likeimage_1.jpg,image_2.jpgand so on. Also, it should be easy to implement additional modifiers in a similar fashion.